3DS Result Object Refactor #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
reviewed
Dec 7, 2023
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "formatVersion": 1, | |||
There was a problem hiding this comment.
I remember seeing this json schema file in another PR. Is it supposed to be in this one?
There was a problem hiding this comment.
Ah no - it was merged in with another PR so now removed 👍
sshropshire
reviewed
Dec 7, 2023
| private void handlePaymentMethodNonceCreated(PaymentMethodNonce paymentMethodNonce) { | ||
| super.onPaymentMethodNonceCreated(paymentMethodNonce); | ||
|
|
||
| final FragmentActivity activity = getActivity(); | ||
| if (!threeDSecureRequested && paymentMethodNonce instanceof CardNonce && | ||
| Settings.isThreeDSecureEnabled(activity)) { | ||
| Settings.isThreeDSecureEnabled(activity) && !(paymentMethodNonce instanceof ThreeDSecureNonce)) { |
There was a problem hiding this comment.
random: Always felt like it would make sense to give 3DSecure its own Demo fragment one day.
sshropshire
reviewed
Dec 7, 2023
ThreeDSecure/src/main/java/com/braintreepayments/api/ThreeDSecureClient.java
Outdated
Show resolved
Hide resolved
…ureClient.java Co-authored-by: sshropshire <[email protected]>
tdchow
reviewed
Dec 11, 2023
Co-authored-by: Tim Chow <[email protected]>
tdchow
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ThreeDSecureResultobject was used throughout the flow to contain the lookup and nonce after the initial lookup call, and after the completion of authentication flow.ThreeDSecureResultobject into aThreeDSecureParamsclass - used to launch theThreeDSecureLauncher, and made all fields exceptThreeDSecureLookupprivate on that class (so merchants can still access intermediate lookup params if desired).ThreeDSecurePaymentAuthRequestobject with aReadyToLaunchstate that contains theThreeDSecureParams, and aLaunchNotRequiredstate that represents a successful 3DS flow where no additional authentication challenge was required. TheLaunchNotRequiredcontainsnonceandlookup. Thenonceandlookupalso do exist on theThreeDSecureParamsobject, but for integration clarity they are separated.ThreeDSecureResultfor the completion of tokenization (full auth challenge completion), which just returns anonceon success - through testing it appears that we don't receive thelookupfrom this API call, so it is not returned again here.Open to suggestions on any changes to make the integration pattern more clear
Checklist
Authors