Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Methods #833

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Remove Deprecated Methods #833

merged 4 commits into from
Nov 28, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Remove deprecated methods and classes

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner November 28, 2023 15:50
Copy link
Contributor

@sshropshire sshropshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -531,7 +501,6 @@ public void writeToParcel(Parcel dest, int flags) {
dest.writeByte((byte) (allowPrepaidCards ? 1 : 0));
dest.writeByte((byte) (payPalEnabled ? 1 : 0));
dest.writeString(environment);
dest.writeString(googleMerchantId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random: Another motivating factor for Kotlin migration worth mentioning is the kotlin-parcelize plugin.

@sarahkoop sarahkoop merged commit dd53d9d into v5 Nov 28, 2023
2 checks passed
@sarahkoop sarahkoop deleted the remove_deprecated branch November 28, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants