Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 3DS APIs #827

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Rename 3DS APIs #827

merged 5 commits into from
Nov 14, 2023

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Rename 3DS APIs to follow createPaymentAuthRequest and tokenize pattern
  • Remove internal continuePerformVerification method and rename startVerificationFlow internal method to sendAnalyticsAndCallbackResult (this method can also likely be refactored and removed when analytics are updated).
  • 3DS is slightly different than the other modules because it uses a single ThreeDSecureResult object for both steps of the flow, there is also a single callback for those results that is used internally and externally. For now, I left the ThreeDSecureResult object naming the same and kept the callback. I've added TODOs to refactor that object and those callbacks in the PR to migrate to a single result object pattern.

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner November 13, 2023 19:58
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sarahkoop sarahkoop merged commit 3c6858c into v5 Nov 14, 2023
@sarahkoop sarahkoop deleted the 3ds_apis_naming branch November 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants