Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FPTI Analytics Event Enums #820
Create FPTI Analytics Event Enums #820
Changes from 18 commits
bb9a228
5f21237
0b7f9b8
b6a3be5
f11b6b0
f56052f
ecdabc1
d9e0c03
37f54ad
c85d335
f871c7a
e8e01ba
71594a6
c0163af
b408140
fcdf942
65d225a
73a0b0e
4857594
196cc8d
c8c5c0e
1ddf5c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - should we add the
// Conversion events
comment here too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS we have a synchronous
bool
return value from ASWeb into if the ASWeb view presented or didn't.Do we have this insight on Android? A way to know if the CCT displayed or didn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BrowserSwitchClient#start
(which launches the CCT) throws aBrowserSwitchException
in some cases, mainly for improper deep linking configuration, but also if the host activity is finishing while trying to launch CCT. In those cases if we receive thatBrowserSwitchException
, we would send thatBROWSER_SWITCH_FAILED
analytic event on Android. So it's not a 1 to 1 match with the iOS meaning of that event, but I think it's still useful for AndroidThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is great - thanks for the explanation