Shopper insights rp2 feature selected event button #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warmkesselj
changed the base branch from
main
to
shopper-insights-rp2-feature
| } | ||
| fun sendSelectedEvent( | ||
| buttonType: ButtonType, | ||
| presentmentDetails: PresentmentDetails |
There was a problem hiding this comment.
I don't think we needed presentment details for this method, just the button type.
sarahkoop
reviewed
Dec 19, 2024
| @@ -189,19 +188,19 @@ class ShopperInsightsClient internal constructor( | |||
| } | |||
|
|
|||
| /** | |||
| * Call this method when the PayPal button has been selected/tapped by the buyer. | |||
| * Call this method when the PayPal, Venmo or Other button has been successfully displayed to the buyer. | |||
There was a problem hiding this comment.
Suggested change
| * Call this method when the PayPal, Venmo or Other button has been successfully displayed to the buyer. | |
| * Call this method when the PayPal, Venmo or Other button has been selected/tapped by the buyer. |
sarahkoop
approved these changes
Dec 19, 2024
warmkesselj
deleted the
shopper-insights-rp2-feature-selected-event-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Refactor
sendPayPalSelectedEvent()andsendVenmoSelectedEvent()tosendSelectedEvent()Checklist
Authors
@jwarmkessel
@warmkesselj