Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all AnalyticsEventParams properties to vals #1243

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update all AnalyticsEventParams properties to vals #1243

merged 1 commit into from
Dec 18, 2024

Conversation

tdchow
Copy link
Collaborator

@tdchow tdchow commented Dec 16, 2024

Summary of changes

  • Update all AnalyticsEventParams properties to vals

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@tdchow tdchow requested a review from a team as a code owner December 16, 2024 19:01
jaxdesmarais
jaxdesmarais approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@tdchow tdchow merged commit 2447b2f into main Dec 18, 2024
3 checks passed
@tdchow tdchow deleted the AnalyticsEventParams-properties branch December 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkoop sarahkoop sarahkoop approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdchow @jaxdesmarais @sarahkoop