Expose paymentId #1220
Merged
Expose paymentId #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdchow
approved these changes
Nov 20, 2024
sarahkoop
reviewed
Nov 21, 2024
| @@ -10,7 +9,6 @@ import com.braintreepayments.api.BrowserSwitchOptions | |||
| * @property approvalUrl used for payment approval. | |||
| * @property paymentId of the local payment after creation. | |||
| */ | |||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
There was a problem hiding this comment.
Is it possible to restrict individual params to library scope? It would be good to keep as much internal as possible to avoid future breaking changes. I think browserSwitchOptions does not need to be accessible if it can be internal.
There was a problem hiding this comment.
@sarahkoop restricted the property browserSwitchOptions.
sarahkoop
reviewed
Nov 21, 2024
sarahkoop
approved these changes
Nov 21, 2024
Co-authored-by: Sarah Koop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors