Convert SEPADirectDebit module classes to Kotlin (#1131)

* Convert SEPADirectDebit module classes to Kotlin * Update CHANGELOG * Chnage CreateMandateResult property mandateType to NonNull * Set SEPADirectDebitInternalTokenizeCallback internal --------- Co-authored-by: Ching-Hsiang Lin <[email protected]>
braintree · Aug 27, 2024 · 8b158f4 · 8b158f4
1 parent 17b2d2c
commit 8b158f4
Show file tree

Hide file tree

Showing 21 changed files with 502 additions and 632 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -149,6 +149,7 @@
         * Move `ThreeDSecureInfo` to `three-d-secure` module
         * Add `CardResult` object
         * Change `CardTokenizeCallback` parameters
+        * Change `BinType` from String to enum
     * SEPA Direct Debit
         * Update package name to `com.braintreepayments.api.sepadirectdebit`
         * Remove `SEPADirectDebitLifecycleObserver` and `SEPADirectDebitListener`

diff --git a/DataCollector/src/test/java/com/braintreepayments/api/datacollector/DataCollectorUnitTest.kt b/DataCollector/src/test/java/com/braintreepayments/api/datacollector/DataCollectorUnitTest.kt
@@ -12,7 +12,6 @@ import io.mockk.every
 import io.mockk.impl.annotations.MockK
 import io.mockk.slot
 import io.mockk.verify
-import org.json.JSONException
 import org.json.JSONObject
 import org.junit.Assert
 import org.junit.Before
@@ -26,7 +25,8 @@ class DataCollectorUnitTest {
     @MockK
     lateinit var context: Context
 
-    @MockK lateinit var configuration: Configuration
+    @MockK
+    lateinit var configuration: Configuration
 
     @MockK
     lateinit var uuidHelper: UUIDHelper
@@ -48,7 +48,6 @@ class DataCollectorUnitTest {
             .build()
 
     @Before
-    @Throws(JSONException::class)
     fun beforeEach() {
 
         MockKAnnotations.init(this, relaxed = true)

diff --git a/...tor/src/test/java/com/braintreepayments/api/datacollector/MagnesInternalClientUnitTest.kt b/...tor/src/test/java/com/braintreepayments/api/datacollector/MagnesInternalClientUnitTest.kt
@@ -73,14 +73,14 @@ class MagnesInternalClientUnitTest {
 
     @Test
     fun getClientMetaDataId_returnsEmptyStringWhenContextIsNull() {
-            val sut = MagnesInternalClient(magnesSDK)
-            val result = sut.getClientMetadataId(
-                null, sandboxConfiguration,
-                dataCollectorInternalRequest
-            )
+        val sut = MagnesInternalClient(magnesSDK)
+        val result = sut.getClientMetadataId(
+            null, sandboxConfiguration,
+            dataCollectorInternalRequest
+        )
 
-            Assert.assertEquals("", result)
-        }
+        Assert.assertTrue(result.isEmpty())
+    }
 
     @Throws(InvalidInputException::class)
     @Test

diff --git a/...ectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/CreateMandateResult.java b/...ectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/CreateMandateResult.java
diff --git a/...irectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/CreateMandateResult.kt b/...irectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/CreateMandateResult.kt
@@ -0,0 +1,9 @@
+package com.braintreepayments.api.sepadirectdebit
+
+data class CreateMandateResult internal constructor(
+    val approvalUrl: String,
+    val ibanLastFour: String,
+    val customerId: String,
+    val bankReferenceToken: String,
+    val mandateType: SEPADirectDebitMandateType
+)
diff --git a/...rectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/SEPADirectDebitApi.java b/...rectDebit/src/main/java/com/braintreepayments/api/sepadirectdebit/SEPADirectDebitApi.java