fix: missing context script task

[abdul99ahad]

Related to camunda-modeler: #4614

Proposed Changes

The context of the script task result variable is now available, providing users with property suggestions for the object.

Checklist

To ensure you provided everything we need to look at your PR:

• Brief textual description of the changes present
• Visual demo attached
• Steps to try out present, i.e. using the @bpmn-io/sr tool
• Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

[barmac]

The code looks OK, and the solution works. There's however one thing about the project which now seems to be confusing.

In the resolver, we call _resolveIoMappings. This results in a call to parseIoMappings. Then we try to get the expression details which now talks about not only iomappings, but also script.

So we move from super specific iomappings talk to general expression-related topics. What I'd rather expect is to start from general resolveVariables and only then to move to specifics like iomappings, script expressions, and whatever comes next.

WDYT?

[abdul99ahad]

So we move from super specific iomappings talk to general expression-related topics. What I'd rather expect is to start from general resolveVariables and only then to move to specifics like iomappings, script expressions, and whatever comes next.

Can you check if my refactoring (ef76957) is accurate? Since we are only differentiating between ioMappings and scriptVariables in getExpressionDetails, I believe having outer functions specific to io is unnecessary (I might be wrong).

[barmac]

Fantastic!

[barmac]

I think it's more readable now, and we don't get a "WTF" for IoMappings.

[barmac]

I missed that in the review, but the commit contained premature "closes" clause:

It should be "Related to..."