Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #31

Merged
merged 9 commits into from
Jan 2, 2025
Merged

Housekeeping #31

merged 9 commits into from
Jan 2, 2025

Conversation

nikku
Copy link
Member

@nikku nikku commented Jan 2, 2025

Proposed Changes

  • bump to eslint@9
  • turn into ES module (contract stays the same)
  • bump test dependencies (drop legacy cruft)

As we previously introduced exports already this should be non breaking.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku added the dependencies Updates a dependency label Jan 2, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 2, 2025
nikku added 8 commits January 2, 2025 09:00
Allows us to use latest mocha + additional test conveniences.

Allows us to drop `esm` test dependency.

No external changes, ESM style bindings were already in place.
@nikku nikku changed the base branch from main to ci-modern January 2, 2025 08:01
@philippfromme philippfromme self-requested a review January 2, 2025 12:43
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🥇

@philippfromme philippfromme merged commit 5c95c8e into ci-modern Jan 2, 2025
4 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 2, 2025
@philippfromme philippfromme deleted the housekeeping branch January 2, 2025 13:36
@philippfromme
Copy link
Contributor

@nikku the target branch of this PR was ci-modern. Should ci-modern be merged into main now?

@nikku
Copy link
Member Author

nikku commented Jan 2, 2025

Yea, I guess so.

@nikku
Copy link
Member Author

nikku commented Jan 2, 2025

Merged ci-modern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants