Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish ESM version of this library #28

Merged
merged 1 commit into from
Aug 28, 2024
Merged

chore: publish ESM version of this library #28

merged 1 commit into from
Aug 28, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Aug 27, 2024

Proposed Changes

We previously did not properly expose ESM configuration of this module, leading to import errors when building ESM only applications.

Closes #27

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

We previously did not properly expose `ESM` configuration of this module, leading to import errors when building `ESM` only applications.

Closes #27
@abdul99ahad
Copy link
Contributor

Everything looks good!

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 28, 2024
@abdul99ahad abdul99ahad reopened this Aug 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 28, 2024
@nikku nikku merged commit 32de099 into main Aug 28, 2024
5 checks passed
@nikku nikku deleted the nikku-patch-1 branch August 28, 2024 10:06
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing while importing bpmn-js-properties-panel (v5.22.0)
2 participants