test: code style

bpmn-io · Jan 2, 2025 · 930eb59 · 930eb59
1 parent 75d7698
commit 930eb59
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/...task-same-output-and-result-variable.bpmn → ...ask-result-variable-output-same-name.bpmn b/...task-same-output-and-result-variable.bpmn → ...ask-result-variable-output-same-name.bpmn
@@ -3,16 +3,16 @@
   <bpmn:process id="Process_1" isExecutable="true">
     <bpmn:scriptTask id="Task_1">
       <bpmn:extensionElements>
-        <zeebe:script expression="=123" resultVariable="foo" />
+        <zeebe:script resultVariable="foo" />
         <zeebe:ioMapping>
-          <zeebe:output source="={}" target="foo" />
+          <zeebe:output target="foo" />
         </zeebe:ioMapping>
       </bpmn:extensionElements>
     </bpmn:scriptTask>
   </bpmn:process>
   <bpmndi:BPMNDiagram id="BPMNDiagram_1">
     <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="Process_1">
-      <bpmndi:BPMNShape id="Activity_0258i89_di" bpmnElement="Task_1">
+      <bpmndi:BPMNShape id="Task_1_di" bpmnElement="Task_1">
         <dc:Bounds x="160" y="60" width="100" height="80" />
       </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>

diff --git a/test/zeebe/fixtures/script-task-output.bpmn → ...s/script-task-result-variable-output.bpmn b/test/zeebe/fixtures/script-task-output.bpmn → ...s/script-task-result-variable-output.bpmn
@@ -3,16 +3,16 @@
   <bpmn:process id="Process_1" isExecutable="true">
     <bpmn:scriptTask id="Task_1">
       <bpmn:extensionElements>
-        <zeebe:script expression="={}" resultVariable="foo" />
+        <zeebe:script resultVariable="foo" />
         <zeebe:ioMapping>
-          <zeebe:output target="output" />
+          <zeebe:output target="bar" />
         </zeebe:ioMapping>
       </bpmn:extensionElements>
     </bpmn:scriptTask>
   </bpmn:process>
   <bpmndi:BPMNDiagram id="BPMNDiagram_1">
     <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="Process_1">
-      <bpmndi:BPMNShape id="Activity_074uvug_di" bpmnElement="Task_1">
+      <bpmndi:BPMNShape id="Task_1_di" bpmnElement="Task_1">
         <dc:Bounds x="160" y="80" width="100" height="80" />
       </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>

diff --git a/test/zeebe/spec/ProcessVariablesSpec.js b/test/zeebe/spec/ProcessVariablesSpec.js
@@ -215,10 +215,10 @@ describe('zeebe/process variables module', function() {
     });
 
 
-    it('should extract variables with re define resultVariable scope if output mapping exists - script task', async function() {
+    it('should extract variables - result variable, output exists - script task', async function() {
 
       // given
-      const xml = read('test/zeebe/fixtures/script-task-output.bpmn');
+      const xml = read('test/zeebe/fixtures/script-task-result-variable-output.bpmn');
 
       const definitions = await parse(xml);
 
@@ -229,16 +229,16 @@ describe('zeebe/process variables module', function() {
 
       // then
       expect(convertToTestable(variables)).to.eql([
-        { name: 'output', origin: [ 'Task_1' ], scope: 'Process_1' },
-        { name: 'foo', origin: [ 'Task_1' ], scope: 'Task_1' },
+        { name: 'bar', origin: [ 'Task_1' ], scope: 'Process_1' },
+        { name: 'foo', origin: [ 'Task_1' ], scope: 'Task_1' }
       ]);
     });
 
 
-    it('should extract only output variable if same name result variable exists - simple process with script', async function() {
+    it('should not extract variables - result variable, output exists with same name - script task', async function() {
 
       // given
-      const xml = read('test/zeebe/fixtures/script-task-same-output-and-result-variable.bpmn');
+      const xml = read('test/zeebe/fixtures/script-task-result-variable-output-same-name.bpmn');
 
       const definitions = await parse(xml);