Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for "Issues for child elements" heading #77

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

rumata28
Copy link
Contributor

@rumata28 rumata28 commented May 28, 2024

When there are issues found by lint rules on a Pool element, a header "Issues for child elements" is added, and that header is not translatable.

PS: I also fixed really minor typos in some of the code comments, and name of one local variable.

@CLAassistant
Copy link

CLAassistant commented May 28, 2024

CLA assistant check
All committers have signed the CLA.

@barmac
Copy link
Member

barmac commented May 29, 2024

Hi, thanks for your submission. However, until you sign the CLA, we cannot look into the changes. It looks that the commit was pushed with a non-GH email.

@rumata28
Copy link
Contributor Author

Hi, signed it, but it is still "pending"///

@barmac
Copy link
Member

barmac commented Jun 3, 2024

It looks like you need to change the commits to use your GitHub email address: https://stackoverflow.com/questions/3042437/how-can-i-change-the-commit-author-for-a-single-commit
Notice that in the PR's commit history, your GitHub handle is not linked to the commits.

@rumata28 rumata28 force-pushed the feat/translate_header branch from f92257a to 6257982 Compare June 5, 2024 13:44
@rumata28
Copy link
Contributor Author

rumata28 commented Jun 5, 2024

yeah.. thanks. updated commit e-mail to match my account.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice little fix, and good cleanups along the way, too!

@nikku nikku merged commit 995a45e into bpmn-io:main Jun 10, 2024
4 checks passed
@nikku
Copy link
Member

nikku commented Jun 10, 2024

Released via v0.22.1.

@nikku nikku added the i18n label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants