Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #794 (bugfix) #826

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Fix for issue #794 (bugfix) #826

merged 4 commits into from
Feb 8, 2024

Conversation

grasdk
Copy link
Contributor

@grasdk grasdk commented Feb 5, 2024

  • Switched from ExifReader to exifr and updated tests and test material to fix issue #794
  • Removed dependency to ExifReader
  • Updated .gitignore
  • Minor clarification added to CONTRIBUTING.md

grasdk and others added 2 commits February 5, 2024 22:35
@grasdk
Feature/specialchars (#2)
1b57926 
* switched from ExifReader to exifr and updated tests to fix issue 794
@grasdk
Reverted to original version of Chars.jpg and test data which does no…
5315e2b 
…t trigger bug bpatrik#794
@grasdk
Copy link
Contributor Author

grasdk commented Feb 5, 2024

While doing this, I discovered a bug with png files having the "createDate" set to the file-date, even if they have metadata embedded. Exifr can read this date metadata from png files, so there are options to further utilize exifr for fixing issues.

I will look into this, but wanted to separate it from the fix of the issue.

@grasdk grasdk marked this pull request as draft February 5, 2024 22:09
@grasdk grasdk marked this pull request as ready for review February 5, 2024 23:11
bpatrik
bpatrik requested changes Feb 6, 2024
View reviewed changes
Copy link
Owner

@bpatrik bpatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice contribution!

Can you please also remove any unused dependencies from the package.json (and also from the lock file)

@grasdk
Copy link
Contributor Author

grasdk commented Feb 7, 2024

Thank you! Nice contribution!

Can you please also remove any unused dependencies from the package.json (and also from the lock file)

Sure. I will do this asap. Hopefully tonight (it's morning here, now). Also the .gitignore

@grasdk grasdk marked this pull request as draft February 7, 2024 06:03
@grasdk grasdk marked this pull request as ready for review February 7, 2024 20:38
@grasdk grasdk requested a review from bpatrik February 7, 2024 20:38
@bpatrik
Copy link
Owner

bpatrik commented Feb 8, 2024

Thank you!

@bpatrik bpatrik merged commit 8c3bd65 into bpatrik:master Feb 8, 2024
5 of 8 checks passed
@grasdk grasdk mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpatrik bpatrik Awaiting requested review from bpatrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grasdk @bpatrik