Adding ability to add custom labels to Lighthouse tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 93.33% 93.43% +0.09%
==========================================
Files 5 5
Lines 135 137 +2
Branches 25 27 +2
==========================================
+ Hits 126 128 +2
Misses 9 9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Added ability to label Lighthouse report and data points.
Why: This can be used to differentiate between reports for same URL made with different Lighthouse plugin confg, for example "desktop" and "mobile". There is no provision to do so in the current setup as reports are saved with the timestamp only and data is added to the database with URL being the only label.
How: I added a parameter called "label" to each Lighthouse config. It's then passed to the functions that save reports and add the data to InfluxDB. If there is no label data is stored in the same format as previously. Otherwise it's stored with ~label added to the end of both filename and the URL for InfluxDB data.
Checklist: