Fix errors with rust v1.83 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
approved these changes
Dec 3, 2024
Comment on lines
672
to
673
| /// // =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= | ||
|
|
||
| /// |
There was a problem hiding this comment.
I think we can remove the /// from line 672.
Comment on lines
9
to
13
| #![expect(non_local_definitions)] | ||
| #![expect(clippy::needless_lifetimes)] |
There was a problem hiding this comment.
Do you mind elaborating that these also come from the StableAbi derive macro?
vigh-m
force-pushed
the
extend-kubernetes-settings
branch
from
fafc6db to
ab14d15
Compare
|
Updated based on comments. |
koooosh
reviewed
Dec 3, 2024
deny.toml
Outdated
| @@ -20,7 +20,7 @@ allow = [ | |||
|
|
|||
| exceptions = [ | |||
| { name = "generational-arena", allow = ["MPL-2.0"] }, | |||
| { name = "unicode-ident", allow = ["MIT", "Apache-2.0", "Unicode-DFS-2016"] }, | |||
| { name = "unicode-ident", allow = ["MIT", "Apache-2.0", "Unicode-DFS-2016", "Unicode-3.0"] }, | |||
There was a problem hiding this comment.
I also have a PR which is failing CI due to this issue. In the CI build, I see this:
registry+https://github.com/rust-lang/crates.io-index#[email protected]:4:36
│
4 │ license = "(MIT OR Apache-2.0) AND Unicode-3.0"
Given this, can we remove the "Unicode-DFS-2016"?
vigh-m
force-pushed
the
extend-kubernetes-settings
branch
from
ab14d15 to
d072a70
Compare
|
Removed extra |
koooosh
approved these changes
Dec 4, 2024
|
Merging this to unblock my PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
unicode-identcrateBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.