Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources: update rust dependencies #331

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Dec 26, 2024

Testing done:

  • smoke-test of aws-ecs-2 variant
  • smoke test of aws-k8s-1.31 variant

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt cbgbt requested review from jpculp, vigh-m and yeazelm December 26, 2024 20:06
@cbgbt cbgbt force-pushed the rust-deps branch 2 times, most recently from 1d13bd1 to 771ecc3 Compare December 26, 2024 20:44
@cbgbt
Copy link
Contributor Author

cbgbt commented Dec 26, 2024

It turns out that the bottlerocket-sdk doesn't know about the Unicode-3.0 license and needs an updated SPDX license identifier list. I'll take a look at that.

@cbgbt
Copy link
Contributor Author

cbgbt commented Jan 4, 2025

This requires a new bottlerocket-sdk with bottlerocket-os/bottlerocket-sdk#234 applied; however, it passes local testing on my machine.

Copy link
Contributor

@yeazelm yeazelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good assuming the SDK change bottlerocket-os/bottlerocket-sdk#234 fixes the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants