-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused variable #858
Conversation
'buf' is unused here
GCOVR code coverage report https://858.url.prtest2.cppalliance.org/gcovr/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #858 +/- ##
===========================================
- Coverage 99.21% 99.21% -0.01%
===========================================
Files 157 157
Lines 8422 8421 -1
===========================================
- Hits 8356 8355 -1
Misses 66 66
Continue to review full report in Codecov by Sentry.
|
@sdarwin the "CI / Runner Selection" step got stuck again (already restarted). |
@alandefreitas , that means the issue has escalated in some way. The first time this happened it seemed to be an isolated event. But now it is repeating, so needs to be investigated more. There was a job missing runners since yesterday. That was the problem. When you restarted the workflow today, it would launch one runner for the selection process. And yesterday's job would steal it. A work-around would be to view what's happening in the Actions page. Completely cancel a failing workflow which is missing a few runners. Then, restart the new workflow from today. Of course, not ideal. Perhaps always-on permanent instances could be launched (drone has that), but it increases costs and complexity, if done per-repo. Something else: ubuntu-latest may still be ubuntu-22.04. Therefore, to install the newest gcc, specify ubuntu-24.04. It's safer to not depend on |
The philips terraform runners are far from perfect in terms of the documentation, and also design. I have discovered this variable:
If an autoscaled instance fails to complete launch within 5 minutes, it is scaled down. And yet, that was happening, and you'd even expect it, because of the extensive amount of the software involved in launching an ec2 instance. It needs to upgrade the github runner package, etc. Increased number to 15 minutes. Theoretically the bug is fixed now. |
@sdarwin OK. I'll keep restarting until it works. |
Again, "theoretically the bug is fixed now." The recent problem was caused by losing runners due to a 5 minute timeout. By setting this to 15 minutes, the runners should not be lost. DM me in Slack if the same issue continues. |
'buf' is unused here