Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variable #858

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

BrianWeed
Copy link
Contributor

'buf' is unused here

'buf' is unused here
@cppalliance-bot
Copy link

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (094a535) to head (8789cf4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #858      +/-   ##
===========================================
- Coverage    99.21%   99.21%   -0.01%     
===========================================
  Files          157      157              
  Lines         8422     8421       -1     
===========================================
- Hits          8356     8355       -1     
  Misses          66       66              
Files Coverage Δ
src/detail/move_chars.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094a535...8789cf4. Read the comment docs.

@alandefreitas
Copy link
Member

@sdarwin the "CI / Runner Selection" step got stuck again (already restarted).

@sdarwin
Copy link
Collaborator

sdarwin commented Aug 16, 2024

@alandefreitas , that means the issue has escalated in some way. The first time this happened it seemed to be an isolated event. But now it is repeating, so needs to be investigated more.

There was a job missing runners since yesterday. That was the problem.

When you restarted the workflow today, it would launch one runner for the selection process. And yesterday's job would steal it.

A work-around would be to view what's happening in the Actions page. Completely cancel a failing workflow which is missing a few runners. Then, restart the new workflow from today. Of course, not ideal.

Perhaps always-on permanent instances could be launched (drone has that), but it increases costs and complexity, if done per-repo.

Something else: ubuntu-latest may still be ubuntu-22.04. Therefore, to install the newest gcc, specify ubuntu-24.04. It's safer to not depend on latest, but specify the required OS tag.

@sdarwin
Copy link
Collaborator

sdarwin commented Aug 16, 2024

The philips terraform runners are far from perfect in terms of the documentation, and also design. I have discovered this variable:

minimum_running_time_in_minutes: 5 (default)

If an autoscaled instance fails to complete launch within 5 minutes, it is scaled down.

And yet, that was happening, and you'd even expect it, because of the extensive amount of the software involved in launching an ec2 instance. It needs to upgrade the github runner package, etc.

Increased number to 15 minutes.

Theoretically the bug is fixed now.

@alandefreitas
Copy link
Member

@sdarwin OK. I'll keep restarting until it works.

@alandefreitas alandefreitas merged commit 4998971 into boostorg:develop Aug 16, 2024
40 of 43 checks passed
@sdarwin
Copy link
Collaborator

sdarwin commented Aug 16, 2024

@sdarwin OK. I'll keep restarting until it works.

Again, "theoretically the bug is fixed now." The recent problem was caused by losing runners due to a 5 minute timeout. By setting this to 15 minutes, the runners should not be lost. DM me in Slack if the same issue continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants