-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user, auth, music 트랜잭션 코드 entity로 이동 #381
Conversation
* Active Record 패턴을 따름 * 사용자 정보 수정, 최근 재생목록 업데이트 로직 옮김
* Active Record 패턴을 따름 * 음악 save, delete 로직 entity 층으로 옮김
* Active Record 패턴을 따름 * 사용자 save, delete 로직 entity 층으로 옮김
* 엔티티에서 트랜잭션이 진행될 때 발생되는 에러 코드를 만들어 추가함
* 에러 처리 확인을 위해 추가했던 콘솔 제거
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 좋은 것 같아요 👍
server/src/user/user.service.ts
Outdated
|
||
return await Recent_Played.getRecentPlayedId(music_id, user_id); | ||
} catch (err) { | ||
await queryRunner.rollbackTransaction(); | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log 빼도 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 감사합니다 제거했습니다 !!
Issue
Overview
To Reviewers