Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user, auth, music 트랜잭션 코드 entity로 이동 #381

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

sk000801
Copy link
Member

Issue

Overview

  • 사용자 save, delete 로직 entity 층으로 옮김
  • 음악 save, delete 로직 entity 층으로 옮김
  • 사용자 정보 수정, 최근 재생목록 업데이트 로직 옮김

To Reviewers

  • 형운님께서 playlist 관련 트랜잭션 코드를 entity로 옮겨주셔서 나머지를 옮겼습니다!
  • 브랜치 보니까 entity error를 새로 만드셔서 playlist 관련 pull request 올려주시면 머지하고 내용 가져와서 entity error를 추가할게요!

* Active Record 패턴을 따름
* 사용자 정보 수정, 최근 재생목록 업데이트 로직 옮김
* Active Record 패턴을 따름
* 음악 save, delete 로직 entity 층으로 옮김
* Active Record 패턴을 따름
* 사용자 save, delete 로직 entity 층으로 옮김
@sk000801 sk000801 added 🛠️ refactor 리팩토링 🖥 server server labels Jan 22, 2024
@sk000801 sk000801 added this to the 🔧 etc milestone Jan 22, 2024
@sk000801 sk000801 self-assigned this Jan 22, 2024
@sk000801 sk000801 requested a review from khw3754 as a code owner January 22, 2024 06:09
* 엔티티에서 트랜잭션이 진행될 때 발생되는 에러 코드를 만들어 추가함
* 에러 처리 확인을 위해 추가했던 콘솔 제거
Copy link
Collaborator

@khw3754 khw3754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 좋은 것 같아요 👍


return await Recent_Played.getRecentPlayedId(music_id, user_id);
} catch (err) {
await queryRunner.rollbackTransaction();
console.log(err);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log 빼도 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 감사합니다 제거했습니다 !!

@sk000801 sk000801 merged commit 6d6475b into develop Jan 22, 2024
1 check passed
@sk000801 sk000801 deleted the server/refactor/372 branch January 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants