Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSLog 사용을 위한 MHLogger 구현 #62

Merged
merged 3 commits into from
Nov 16, 2024
Merged

OSLog 사용을 위한 MHLogger 구현 #62

merged 3 commits into from
Nov 16, 2024

Conversation

Kyxxn
Copy link
Member

@Kyxxn Kyxxn commented Nov 15, 2024 •
edited
Loading

#️⃣ 연관된 이슈


⏰ 작업 시간

예상 시간 실제 걸린 시간
1 min 1 hour

📝 작업 내용

  • 프로젝트 내에서 print가 아닌,
    OSLog를 사용하기 위해 Core 계층에 Logger를 두었습니다.

📒 리뷰 노트

  • 4가지 케이스로 나눠뒀습니다, 상황에 따라 쓰시면 될 것 같아요!
  • 사용 예시
    스크린샷 2024-11-16 오전 4 22 48

@Kyxxn Kyxxn added the ✨ Feature 기능 관련 작업 label Nov 15, 2024
@Kyxxn Kyxxn added this to the 0.2 milestone Nov 15, 2024
@Kyxxn Kyxxn self-assigned this Nov 15, 2024
@Kyxxn Kyxxn linked an issue Nov 15, 2024 that may be closed by this pull request
Logger 구현 #61
Closed
@Kyxxn Kyxxn changed the title MHLogger 구현 OSLog 사용을 위한 MHLogger 구현 Nov 15, 2024
yuncheol-AHN
yuncheol-AHN approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@yuncheol-AHN yuncheol-AHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🍎

k2645
k2645 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@k2645 k2645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오아앙 효준님 너무 수고하셨고 감사합니다 .ᐟ.ᐟ 🥹🥹🥹 잘 사용하겠숩니당 😋

iceHood
iceHood approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@iceHood iceHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니당!!

@Kyxxn Kyxxn merged commit 1ad7b14 into develop Nov 16, 2024
2 checks passed
@Kyxxn Kyxxn deleted the feature/set-logger branch November 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceHood iceHood iceHood approved these changes

@yuncheol-AHN yuncheol-AHN yuncheol-AHN approved these changes

@k2645 k2645 k2645 approved these changes

Assignees

@Kyxxn Kyxxn

Labels
✨ Feature 기능 관련 작업
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

Logger 구현
4 participants
@Kyxxn @k2645 @yuncheol-AHN @iceHood