-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BookCover 생성 및 수정 기능 구현 #120
Conversation
- CreateBookCoverViewModel 로직만 완성 - MemorialHouseName 가져오기 로직 필요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !!!!
코드 퀄리티가 너무 야무지네요
|
||
final class CreateBookCoverViewModel: ViewModelType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO 로 에러처리 적어주실 수 있나용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
적용했숩니다 ~.ᐟ.ᐟ
|
||
final class ModifyBookCoverViewModel: ViewModelType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 에러처리 TODO 부탁드립니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기두 적용했숩니다 ~.ᐟ.ᐟ
output | ||
.receive(on: DispatchQueue.main) | ||
.sink { [weak self] event in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
대영현 ;;; 이걸 해결하다니 멋있습니다
@@ -42,11 +40,10 @@ public final class HomeViewModel: ViewModelType { | |||
self.deleteBookCoverUseCase = deleteBookCoverUseCase | |||
} | |||
|
|||
@MainActor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥.... 신이야....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
영빛
#️⃣ 연관된 이슈
⏰ 작업 시간
📝 작업 내용
📸 스크린샷
📒 리뷰 노트