Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BookCover 생성 및 수정 기능 구현 #120

Merged
merged 11 commits into from
Dec 2, 2024
Merged

Conversation

k2645
Copy link
Collaborator

@k2645 k2645 commented Dec 2, 2024

#️⃣ 연관된 이슈


⏰ 작업 시간

예상 시간 실제 걸린 시간
2 5

📝 작업 내용

  • BookCover 생성 로직 구현
  • BookCover 수정 로직 구현
  • BookCover 저장 및 삭제 (생성 뷰의 경우..)

📸 스크린샷

BookCover 생성 BookCover 수정

📒 리뷰 노트

  • 다음 Task에서 사진 추가 기능을 연동해야합니다.
  • 에러 처리가 필요합니다.

@k2645 k2645 added ✨ Feature 기능 관련 작업 👷‍♂️ Refactor 코드 개선, 가독성 개선, 주석 labels Dec 2, 2024
@k2645 k2645 added this to the 0.5 milestone Dec 2, 2024
@k2645 k2645 self-assigned this Dec 2, 2024
@k2645 k2645 linked an issue Dec 2, 2024 that may be closed by this pull request
Copy link
Member

@Kyxxn Kyxxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!!!
코드 퀄리티가 너무 야무지네요

Comment on lines 5 to 6

final class CreateBookCoverViewModel: ViewModelType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO 로 에러처리 적어주실 수 있나용

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용했숩니다 ~.ᐟ.ᐟ

Comment on lines 4 to 5

final class ModifyBookCoverViewModel: ViewModelType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 에러처리 TODO 부탁드립니다 !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기두 적용했숩니다 ~.ᐟ.ᐟ

Comment on lines +95 to +97
output
.receive(on: DispatchQueue.main)
.sink { [weak self] event in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대영현 ;;; 이걸 해결하다니 멋있습니다

@@ -42,11 +40,10 @@ public final class HomeViewModel: ViewModelType {
self.deleteBookCoverUseCase = deleteBookCoverUseCase
}

@MainActor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다..

Copy link
Collaborator

@iceHood iceHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥.... 신이야....

Copy link
Collaborator

@yuncheol-AHN yuncheol-AHN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영빛

@k2645 k2645 merged commit bfb453c into develop Dec 2, 2024
2 checks passed
@k2645 k2645 deleted the feature/save-book-cover branch December 2, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 관련 작업 👷‍♂️ Refactor 코드 개선, 가독성 개선, 주석
Projects
None yet
Development

Successfully merging this pull request may close these issues.

책 커버 저장로직 구현
4 participants