Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The git var GIT_EDITOR fatal behaviour was likely never important #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

The git var GIT_EDITOR fatal behaviour was likely never important #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions t/20-simple.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,25 +74,6 @@ $r->run( add => 'readme.txt' );
# unset all editors
delete @ENV{qw( EDITOR VISUAL GIT_EDITOR )};

SKIP: {
BEGIN { $tests += 2 }
skip "these tests require git >= 1.6.6, but we only have $version", 2
if Git::Repository->version_lt('1.6.6');

skip "editor defined directly in .gitconfig", 2
if $r->run( config => 'core.editor' );

skip "this test does not work with msysgit on Win32", 2
if $^O eq 'MSWin32';

ok( !eval { $r->run( var => 'GIT_EDITOR' ); 1; }, 'git var GIT_EDITOR' );
like(
$@,
qr/^fatal: Terminal is dumb, but EDITOR unset /,
'Git complains about lack of smarts and editor'
);
}

# with git commit it's not fatal
BEGIN { $tests += 4 }
SKIP: {
Expand Down