Fix width/height change via prop change #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pionl
force-pushed
the
fix-state-prop-update
branch
3 times, most recently
from
94f898b to
a422370
Compare
When changing size (first 200x300) and then changing it to different value (300x200) the render is rendering size correctly, but when starting to drag a corner, the size is changed back to 200x300 until I move mouse. This is caused by different size in state.
pionl
force-pushed
the
fix-state-prop-update
branch
from
a422370 to
90ec1d3
Compare
|
@pionl Thanks for your PR. Could you please provide reproduced sample in webpackbin if you get a chanece? |
|
Sure thing, on this easy test you can see the incorrect size after clicking the button and using resize. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending first size via prop (200x300), and then changing size via
prop (300x200) then the state has old size (200x300) but renderers
200x300 until onResizeStart is started (renders 300x200) until
onMouseMove is triggered.