Fix ReadStorageAt #302
Open
Fix ReadStorageAt #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyellick
approved these changes
Feb 25, 2025
mmontour1306
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
I'll approve this as a temporary fix for a testnet, but in general the function should not override an explicitly specified blockHash as this could pass incorrect state information back to the caller. This change also bypasses the "s.trustRPC" flag and treats it as true for chainId 97.
boyuan-chen
had a problem deploying
to
op-stack-production
GitHub Actions
Failure
boyuan-chen
temporarily deployed
to
op-stack-production
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, starting from the last night, all bcs endpoints don't support to get the storage according to the block hash. I tried the ankr, quicknode, but none of them supports it.