Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Eq, Ord impls on FiniteF64 #187

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Eq, Ord impls on FiniteF64 #187

wants to merge 2 commits into from

Conversation

sffc
Copy link

@sffc sffc commented Jan 27, 2025

Since they are finite, can we implement Eq?

jedel1043
jedel1043 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small typo and we can merge this after appeasing clippy.

src/primitive.rs Outdated Show resolved Hide resolved
jasonwilliams
jasonwilliams approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jasonwilliams jasonwilliams left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although you will have to remove partialOrd & partialEq from Finite64 (see lint error)

@sffc @jedel1043
Update src/primitive.rs
3a68d54 
Co-authored-by: José Julián Espina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwilliams jasonwilliams jasonwilliams approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sffc @jasonwilliams @jedel1043