Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Duration parsing not returning a range error. #173

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 21, 2025

Per title, parsing should return a range error and not a general error.

@nekevss nekevss added the C-bug Something isn't working label Jan 21, 2025
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jedel1043 jedel1043 force-pushed the patch-duration-parsing branch from a64d1a7 to 37e5731 Compare January 22, 2025 03:34
@jedel1043 jedel1043 merged commit 59bd045 into main Jan 22, 2025
6 checks passed
@jedel1043 jedel1043 deleted the patch-duration-parsing branch January 22, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants