Enables the standard-conforming preprocessor with MSVC /Zc:preprocessor and fixes resulting errors #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewcorrigan
force-pushed
the
master
branch
from
5cc7963 to
fa7e7a7
Compare
|
Hi @andrewcorrigan , thanks for the PR! It is not clear to me why only MSVC is complaining about these macros, since neither GCC nor clang have ever complained about them (even in strict C++ conformance mode). Given previous experience with MSVC, I would suspect a bug... In any case, I thinks this is an acceptable compromise. I want to slightly rework the build system bits, I will try to do this in the weekend and then issue a new mp++ release. |
Merged
|
Replaced by #320. |
|
Replaced by #320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the standard-conforming preprocessor with MSVC /Zc:preprocessor and fixes resulting errors
/Zc:preprocessor: https://github.com/andrewcorrigan/mppp/actions/runs/11838858846/job/32988951135