Remove CLI ESBuild step #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix aims to address various ESBuild issues of users by removing the ESBuild step from the CLI commands and parsing parsing the OpenAPI spec directly from TS/JS files without any build step by using tsx. The `generate` and `validate` functions are now also exposed as entry points for the ESBuild output, allowing those functions to be used for custom CLIs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blomqma
force-pushed
the
cli-esbuild-fix
branch
from
5e3e980 to
26cac4f
Compare
This allows testing that API routes with third-party dependencies like JSDom don't cause issues in the OpenAPI generation. This commit also adds an example on writing custom scripts for generating/validating the OpenAPI spec. The deep object comparison as part of the OpenAPI generation/validation is also replaced with a faster stringified comparison between the generated and existing OpenAPI specs. Co-authored-by: Austin Kelleher <[email protected]>
blomqma
force-pushed
the
cli-esbuild-fix
branch
from
26cac4f to
d72becb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aims to address various ESBuild issues of users by removing the ESBuild step from the CLI
commands and parsing parsing the OpenAPI spec
directly from TS/JS files without any build step by using tsx.
The
generateandvalidatefunctions are nowalso exposed as entry points for the ESBuild output, allowing those functions to be used for custom CLIs.
The second commit also includes verifying that the CLI commands work with third-party dependencies, raised in this PR: #160