Fix CLI bundling glob for npm/npx #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ESBuild process for the CLI commands fails when run with npm/npx due to the dependencies being resolved differently than with pnpm, resulting in the dependencies at node_modules folder being resolved by ESBuild when running the CLI commands with npm/npx. To fix this, the `tiny-glob` package is replaced with an alternative `fast-glob` that allows us to explicitly exclude all node_modules files from the globbing output, fixing the issue.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESBuild process for the CLI commands
fails when run with npm/npx due to the dependencies being resolved differently than with pnpm, resulting in the dependencies at node_modules folder being resolved by ESBuild when running the CLI commands with npm/npx.
To fix this, the
tiny-globpackage is replaced with an alternativefast-globthat allows us to explicitly exclude all node_modules files from the globbing output, fixing the issue.