fix data structure to merge #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
blomqma
reviewed
Dec 16, 2023
| return false; | ||
| } | ||
| return 'paths' in x; | ||
| }; |
There was a problem hiding this comment.
Could you move this utility to the same file as the CLI script as this is only used by the CLI commands, thanks.
There was a problem hiding this comment.
ok. I moved it to the CLI script file.
blomqma
requested changes
Dec 16, 2023
There was a problem hiding this comment.
Thanks for discovering and fixing this! I had one suggestion for moving the utility function to the CLI script file. Could you also remove the first commit of updating the lock file as I'm about to do some version upgrades for various packages soon which will update the lock file. The updated lock file version also fails on the CI and it should pass if you remove the first commit.
roothybrid7
force-pushed
the
fix-merge-data-by-cli
branch
from
b5e69e5 to
be02f24
Compare
roothybrid7
force-pushed
the
fix-merge-data-by-cli
branch
from
be02f24 to
faf5170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with the way the data was merged and I fixed it.