Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed thirdweb icon in /docs #2339

Closed

Conversation

suryanshkushwaha
Copy link

@suryanshkushwaha suryanshkushwaha commented Jan 17, 2025

Description

  1. The codebase had accidentally changed the blockchain icon to thirdweb icon which I have corrected.
image
  1. Ran prettier format

  2. Fixed the thirdweb svg to be visible in the footer

image

PLEASE NOTE- Checklist must be complete prior to review.

Docs Checklist

@suryanshkushwaha suryanshkushwaha marked this pull request as draft January 17, 2025 11:36
fixed the thirbweb icon svg to be visible on the site
removed thirdweb icon which i had added initially
@suryanshkushwaha suryanshkushwaha marked this pull request as ready for review January 17, 2025 12:08
@suryanshkushwaha suryanshkushwaha changed the title Added thirdweb icon in docs Fixed thirdweb icon in docs Jan 17, 2025
@suryanshkushwaha suryanshkushwaha changed the title Fixed thirdweb icon in docs Fixed thirdweb icon in /docs Jan 17, 2025
@gregfromstl
Copy link
Collaborator

Hey @suryanshkushwaha, thirdweb has acquired Web3Onboard so this change was intentional.

@suryanshkushwaha
Copy link
Author

@gregfromstl I understand, then in that case, I found a couple of bugs/errors

  • missing thirdweb svg in docs/components/icons
  • the footer svg not visible because of the background
  • onboard still showing "powered by blocknative"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants