-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pygrib as a dependency; manually parse coordinate reference system from eccodes keys #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for addressing this, we ran into this issue too running on Linux containers and would have contributed but were just as puzzled. Likely a memory issue in pygrib so I like this solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues with pygrib after its latest release (something to do with numpy 2+ releases). Pygrib was working fine on my personal computer, but I was getting segmentation faults in my GitHub Actions tests. I decided to drop pygrib as a dependency since I was only using it to parse the coordinate reference system (CRS) when loading the data into xarray. It's not too painful to just parse the CRS info (in CF-compliant form) from what cfgrib can provide. I wish cfgrib would handle the CF grid specification itself (ecmwf/cfgrib#251) but I can let Herbie do it for now. Maybe I'll contribute to cfgrib if I have some free time.
Also, fixed the GitHub Actions tests!