Added ability to "drape" line PolyData over a warped mesh. #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refctored some of geometry.py to load in arbitrary natural Earth features (e.g. country borders). Example added using LFRic orog and Natural Earth country borders.
ukmo-ccbunney
added
new: feature
|
🚀 Awesome! Your first pull request! Thanks for contributing to |
github-actions
bot
added
type: examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Provides functionality to "drape" a line PolyMesh (e.g. coastlines, country borders) over an existing mesh that has been warped.
Achieves this by extruding the line mesh upwards and downwards in the geographical vertical direction to create a "wall". The intersection of this with the user provided warped mesh is then calculated and returned as a PolyMesh.
Unfortunately, this can be a very computationally expensive process if either the mesh or the line feature are anything more than course resolution (e.g. 110m resolution for a lines mesh is ok, 50m is slow, 10m is very very slow).
Required some some refactoring of the "coastline" methods in
geometry.pyto load in arbitrary natural Earth features (e.g. country borders). The actual intersection is done in theload_natural_earth_featuremethod.Example added using LFRic orog and Natural Earth country borders: