-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15807]Move subscription to 'canceled' 7 days after unpaid #5221
Open
cyprain-okeke
wants to merge
11
commits into
main
Choose a base branch
from
pm-15807-Move-subscription-to-canceled-7-days-after-unpaid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[PM-15807]Move subscription to 'canceled' 7 days after unpaid #5221
cyprain-okeke
wants to merge
11
commits into
main
from
pm-15807-Move-subscription-to-canceled-7-days-after-unpaid
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cy Okeke <[email protected]>
Signed-off-by: Cy Okeke <[email protected]>
Signed-off-by: Cy Okeke <[email protected]>
Signed-off-by: Cy Okeke <[email protected]>
…nceled-7-days-after-unpai'' into pm-15807-Move-subscription-to-canceled-7-days-after-unpai'
jonashendrickx
approved these changes
Jan 6, 2025
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5221 +/- ##
==========================================
- Coverage 43.69% 43.65% -0.05%
==========================================
Files 1469 1470 +1
Lines 67898 67965 +67
Branches 6156 6164 +8
==========================================
Hits 29670 29670
- Misses 36934 37001 +67
Partials 1294 1294 ☔ View full report in Codecov by Sentry. |
jonashendrickx
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15807
📔 Objective
7 days after a subscription moves to an unpaid status, we cancel the subscription.
we void any associated invoices
CS needs some way to override this behavior. Could be as simple as their current workflow, which is to mark the org as enabled.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes