Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16512] Enable Automatic Tax for all subscriptions #5210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16512

📔 Objective

We were incorrectly setting the automatic tax calculation flag based on the state of another object. This could potentially cause some customers to not being charged sales tax in the future. We can confidently always enable this and let Stripe handle the calculations.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…are-being-created-without-automatic_tax_enabled-set-to-false

# Conflicts:
#	src/Core/Billing/Services/Implementations/SubscriberService.cs
@jonashendrickx jonashendrickx requested a review from a team as a code owner January 3, 2025 08:11
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.72%. Comparing base (03feb03) to head (7652c87).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/Services/Implementations/StripePaymentService.cs 22.72% 17 Missing ⚠️
...Services/Implementations/UpcomingInvoiceHandler.cs 0.00% 1 Missing ⚠️
...ices/Implementations/OrganizationBillingService.cs 0.00% 1 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5210      +/-   ##
==========================================
+ Coverage   43.69%   43.72%   +0.02%     
==========================================
  Files        1469     1469              
  Lines       67898    67873      -25     
  Branches     6156     6146      -10     
==========================================
+ Hits        29670    29678       +8     
+ Misses      36934    36907      -27     
+ Partials     1294     1288       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details8c8f345b-b118-4b1a-a016-0dcc64a89ab8

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/RecoveryController.cs: 38
MEDIUM CSRF /src/Billing/Controllers/StripeController.cs: 164
MEDIUM Privacy_Violation /src/Api/Auth/Models/Request/Accounts/SetPasswordRequestModel.cs: 28
LOW Log_Forging /src/Api/Auth/Controllers/EmergencyAccessController.cs: 159
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 927
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 261
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 381

…are-being-created-without-automatic_tax_enabled-set-to-false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants