Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16607] - Removed feature flag logic pm-3479-secure-org-group-details #5209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Jan 2, 2025

🎟️ Tracking

PM-16607

📔 Objective

Remove obsolete feature flagged logic for Secure Organization Group Details endpoint changes. This also removes the feature flag completely since the flag was only used on the server and only affected the web client.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner January 2, 2025 16:39
@jrmccannon jrmccannon requested a review from JimmyVo16 January 2, 2025 16:39
Copy link
Contributor

github-actions bot commented Jan 2, 2025

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
[H1] Implement new group-details endpoint pm-3479-secure-org-group-details ✅ all references removed

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Logo
Checkmarx One – Scan Summary & Details0c95cf4b-4880-4015-8ea3-3546830e23a8

No New Or Fixed Issues Found

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 43.35%. Comparing base (1062c6d) to head (fa41970).

Files with missing lines Patch % Lines
...c/Api/AdminConsole/Controllers/GroupsController.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5209   +/-   ##
=======================================
  Coverage   43.34%   43.35%           
=======================================
  Files        1458     1458           
  Lines       66517    66510    -7     
  Branches     6081     6079    -2     
=======================================
  Hits        28835    28835           
+ Misses      36390    36383    -7     
  Partials     1292     1292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants