Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #5201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11730

📔 Objective

Removes the Stripe Sources API Deprecation feature flag.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

LaunchDarkly flag references

❌ 1 flag removed

Name Key Aliases found Info
Remove Integration with Stripe's Sources API AC-2476-deprecate-stripe-sources-api ✅ all references removed

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.22%. Comparing base (9e7d1ab) to head (189a449).

Files with missing lines Patch % Lines
src/Core/Services/Implementations/UserService.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5201      +/-   ##
==========================================
+ Coverage   44.09%   44.22%   +0.12%     
==========================================
  Files        1476     1476              
  Lines       68273    68222      -51     
  Branches     6181     6171      -10     
==========================================
+ Hits        30106    30172      +66     
+ Misses      36857    36740     -117     
  Partials     1310     1310              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Logo
Checkmarx One – Scan Summary & Details359c8485-9c26-4fc3-a29e-a0b4a68b6aba

New Issues (6)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 66
detailsMethod PostIpn at line 66 of /src/Billing/Controllers/PayPalController.cs gets a parameter from a user request from Body. This parameter value flow...
Attack Vector
MEDIUM Privacy_Violation /src/Core/AdminConsole/OrganizationAuth/UpdateOrganizationAuthRequestCommand.cs: 84
detailsMethod UpdateAsync at line 84 of /src/Core/AdminConsole/OrganizationAuth/UpdateOrganizationAuthRequestCommand.cs sends user information outside the...
Attack Vector
MEDIUM Privacy_Violation /src/Core/NotificationHub/NotificationHubPushNotificationService.cs: 195
detailsMethod PushAuthRequestAsync at line 195 of /src/Core/NotificationHub/NotificationHubPushNotificationService.cs sends user information outside the a...
Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 173
detailsMethod ToCipherLoginData at line 173 of /src/Api/Vault/Models/Request/CipherRequestModel.cs sends user information outside the application. This ma...
Attack Vector
MEDIUM Privacy_Violation /src/Api/Vault/Models/Request/CipherRequestModel.cs: 202
detailsMethod ToCipherIdentityData at line 202 of /src/Api/Vault/Models/Request/CipherRequestModel.cs sends user information outside the application. This...
Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/DomainClaimedByOrganization.html.hbs: 7
detailsA Content Security Policy is not explicitly defined within the web-application.
Attack Vector
Fixed Issues (22)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Tools/Controllers/OrganizationExportController.cs: 53
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 470
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 65
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/PoliciesController.cs: 46
MEDIUM CSRF /src/Admin/AdminConsole/Controllers/OrganizationsController.cs: 371
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 80
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 121
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 259
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 639
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 185
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 170
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72

jonashendrickx
jonashendrickx previously approved these changes Dec 31, 2024
JimmyVo16
JimmyVo16 previously approved these changes Dec 31, 2024
@jrmccannon jrmccannon removed their request for review January 3, 2025 14:04
@amorask-bitwarden
Copy link
Contributor Author

@cturnbull-bitwarden @JimmyVo16 Had some merge conflicts here if you two don't mind re-reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants