-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #5201
base: main
Are you sure you want to change the base?
[PM-11730] Remove feature flag: AC-2476-deprecate-stripe-sources-api #5201
Conversation
LaunchDarkly flag references❌ 1 flag removed
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5201 +/- ##
==========================================
+ Coverage 44.09% 44.22% +0.12%
==========================================
Files 1476 1476
Lines 68273 68222 -51
Branches 6181 6171 -10
==========================================
+ Hits 30106 30172 +66
+ Misses 36857 36740 -117
Partials 1310 1310 ☔ View full report in Codecov by Sentry. |
New Issues (6)Checkmarx found the following issues in this Pull Request
Fixed Issues (22)Great job! The following issues were fixed in this Pull Request
|
8de6250
@cturnbull-bitwarden @JimmyVo16 Had some merge conflicts here if you two don't mind re-reviewing. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11730
📔 Objective
Removes the Stripe Sources API Deprecation feature flag.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes