-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pm-337] Remove the continuation token from the ListResponseModel. #5192
Open
JimmyVo16
wants to merge
2
commits into
main
Choose a base branch
from
ac/pm-337/remove-continuation-token-from-base-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[pm-337] Remove the continuation token from the ListResponseModel. #5192
JimmyVo16
wants to merge
2
commits into
main
from
ac/pm-337/remove-continuation-token-from-base-model
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5192 +/- ##
==========================================
- Coverage 43.70% 43.69% -0.01%
==========================================
Files 1469 1470 +1
Lines 67901 67901
Branches 6156 6156
==========================================
- Hits 29673 29671 -2
- Misses 36934 36936 +2
Partials 1294 1294 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
eliykat
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-337
📔 Objective
Moved the
ContinuationToken
property fromListResponseModel
toPagedListResponseModel
, ensuring it only appears on theGET public/events
endpoint and not on others that don’t require it.📸 Screenshots
GET public/events
docSpot-check
GET /public/members
doc to ensure that it doesn't haveContinuationToken
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes