Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat4::frustum_{lh,rh{,_gl}} #529

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

valaphee
Copy link

Solves #441

@valaphee
Copy link
Author

valaphee commented Jun 21, 2024

perspective could be built on top of frustum, but would incur some overhead, and the test currently works by comparing perspective, with frustum.

Could change the test to also check projections.

@bitshifter
Copy link
Owner

Thanks for taking this on!

It looks like clippy is failing because perspective is unused in the tests you've added, from your comment above it sounded like you were intending to use that value in the test though?

As for perspective being constructed from frustum, I don't have a strong opinion. Re-use is nice when it makes sense and a little perf hit isn't that big a deal IMO in these as I think they're not usually frequently called in hot code, but what might that look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants