Update setup.js in attempt to get colour borders to work #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the colour choices need to start with a capital letter to work. This is not what it says in the manual but I have had success getting it to work this way.
|
We'll need to do an upgrade script for this because it is a breaking change. |
|
Is that something I can assist with? |
|
Can this be progressed to enable a merge? I think a few people would like to see the borders working, especially useful for tally. |
It's not related to the communication protocol. By testing with netcat I can confirm, capital and non capital colors work both. Problem is that color definition get's translated to
I will test the fix when I'm back on site. |
|
ohhh ... I see it. I can fix tonight probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the colour choices need to start with a capital letter to work. This is not what it says in the manual but I have had success getting it to work this way.