feat(client): add async and blocking clients to submit txs package #114
Conversation
src/api.rs
Outdated
|
|
||
| #[derive(Deserialize, Debug)] | ||
| pub struct MempoolFeesSubmitPackage { | ||
| pub base: f64, |
There was a problem hiding this comment.
What is base here?
Can you leave a comment
There was a problem hiding this comment.
looks good, let just some nits. can confirm that the calls match the endpoint added in my pr on esplora (Blockstream/electrs#119)
acidbunny21
force-pushed
the
submit-tx-pkg-clients
branch
2 times, most recently
from
6a22216 to
01fb9c9
Compare
Pull Request Test Coverage Report for Build 12930470174Details
💛 - Coveralls |
Cargo.toml
Outdated
| @@ -18,6 +18,7 @@ path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
There was a problem hiding this comment.
Can we disable default features here and only enable the features we actually need?
src/api.rs
Outdated
|
|
||
| #[derive(Deserialize, Debug)] | ||
| pub struct TxResult { | ||
| pub txid: String, |
There was a problem hiding this comment.
Let's deserialize these into actual types, not String everywhere (see https://github.com/rust-bitcoin/corepc/blob/b62e8c84e3271e57b10849d27191c0357711660b/types/src/model/raw_transactions.rs#L17-L58 for examples).
There was a problem hiding this comment.
updated. I also added the same comments on the fields as the ones in rust-bitcoin
src/async.rs
Outdated
| /// if `maxburnamount` is provided, any transaction | ||
| /// with higher provably unspendable outputs amount | ||
| /// will be rejected | ||
| pub async fn broadcast_package( |
There was a problem hiding this comment.
Lets call this submit_package to avoid introducing a new separate terminology?
acidbunny21
force-pushed
the
submit-tx-pkg-clients
branch
from
01fb9c9 to
a5322c6
Compare
| pub struct SubmitPackageResult { | ||
| /// The transaction package result message. "success" indicates all transactions were accepted | ||
| /// into or are already in the mempool. | ||
| pub package_msg: String, |
There was a problem hiding this comment.
Do we know if the variants here are finite? Do we see a chance to parse this into an enum?
Counterpart PR for Blockstream/electrs#119 to enable submitpackage API