-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize justfile task names and parameters across projects #529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Also the alphabetical ordering cleans it up between files. ACK 44d6d3c.
Would you mind adding a new command while we're at it? A lot of other repos I've see use the following:
default:
just --list
Which allows you to print the recipes for each directory you're in simply by calling just
.
awesome suggestion, I was actually wondering about that! You seem to be doing this a lot lately (answering questions I had bubbling around my head before I even asked them out loud), its great- |
WalkthroughThe updates across various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7d95157.
Description
Update task names in justfiles to improve clarity and consistency.
This was based on me using and thinking about it since
just
was introduced (lovingjust
!).Notes to reviewers
The main rule of thumb was VERB-NOUN (for example:
test-offline
) which was being used mostly but I just made sure we were using consistently across all files.Changes ensure clear understanding and usage across multiple platforms (bdk-jvm, bdk-android, etc.).
If you'd like
test-specific
to betest-one
I'm totally ok with that even though I slightly preferredtest-specific
per what I could intuit from other naming conventions. Or if you prefer any other naming conventions I'm open to it.Changelog notice
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingNew Features:
Bugfixes: