Improve error handle for Ledger
devices
#718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered it while reviewing #bitcoin/24313. The
ledger_exception
function was not dealing withApduException
exceptions. It's basically similar toBTChipException
and we can use its "error code" to return friendly error messages.e.g for
displayaddress
:before:
{"error": "Exception: invalid status 0x6985", "code": -13}
after:
{"error": "display_singlesig_address canceled", "code": -14}