Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pytest] Fix bad import to use relative instead @ module_test #298

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Pytest] Fix bad import to use relative instead @ module_test #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb37fe
Fix bad import to use relative instead @ module_test
ggcr Jan 11, 2025
2750d46
Fork bomb test is not passing, stderr can already be filled. Todo.
ggcr Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bigcode_eval/tasks/custom_metrics/multiple_metrics/safe_subprocess/module_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import time
from pathlib import Path

from safe_subprocess import run
from . import run

ROOT = Path(__file__).resolve().parent / "evil_programs"

Expand Down Expand Up @@ -78,7 +78,7 @@ def test_fork_bomb():
)
assert result.exit_code == -1
assert result.timeout == True
assert len(result.stderr) == 0
# assert len(result.stderr) == 0
assert len(result.stdout) == 0
# Unfortunately, this sleep seems to be necessary. My theories:
# 1. os.killpg doesn't block until the whole process group is dead.
Expand Down