Skip to content

Commit

Permalink
allowHoverUnitStrafing modrule defaults to false (#1871)
Browse files Browse the repository at this point in the history
Previously defaulted to false for HAPFS and true for QTPFS,
so this change reduces interdependency and opaqueness and
makes it easier to document.

HAPFS is the default so this won't affect "the" defaults.
All known games set hover strafing explicitly, too.
  • Loading branch information
sprunk authored Jan 8, 2025
1 parent cec8d5c commit 41247b3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rts/Sim/Misc/ModInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void CModInfo::ResetState()
allowUnitCollisionOverlap = true;
allowSepAxisCollisionTest = false;
allowGroundUnitGravity = false;
allowHoverUnitStrafing = true;
allowHoverUnitStrafing = false;

maxCollisionPushMultiplier = std::numeric_limits<float>::infinity();
unitQuadPositionUpdateRate = 3;
Expand Down Expand Up @@ -200,7 +200,7 @@ void CModInfo::Init(const std::string& modFileName)
allowUnitCollisionOverlap = movementTbl.GetBool("allowUnitCollisionOverlap", allowUnitCollisionOverlap);
allowSepAxisCollisionTest = movementTbl.GetBool("allowSepAxisCollisionTest", allowSepAxisCollisionTest);
allowGroundUnitGravity = movementTbl.GetBool("allowGroundUnitGravity", allowGroundUnitGravity);
allowHoverUnitStrafing = movementTbl.GetBool("allowHoverUnitStrafing", (pathFinderSystem == QTPFS_TYPE));
allowHoverUnitStrafing = movementTbl.GetBool("allowHoverUnitStrafing", allowHoverUnitStrafing);
maxCollisionPushMultiplier = movementTbl.GetFloat("maxCollisionPushMultiplier", maxCollisionPushMultiplier);
unitQuadPositionUpdateRate = std::clamp(movementTbl.GetInt("unitQuadPositionUpdateRate", unitQuadPositionUpdateRate), 1, 15);
groundUnitCollisionAvoidanceUpdateRate = std::clamp(movementTbl.GetInt("groundUnitCollisionAvoidanceUpdateRate", groundUnitCollisionAvoidanceUpdateRate), 1, 15);
Expand Down

0 comments on commit 41247b3

Please sign in to comment.