Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect bevy_input_focus #17212

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Reflect bevy_input_focus #17212

merged 3 commits into from
Jan 7, 2025

Conversation

chompaa
Copy link
Member

@chompaa chompaa commented Jan 7, 2025

Objective

Fixes #17099.

Solution

Derive, register, and feature flag.

Testing

Ran CI.

@chompaa chompaa added A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 7, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 7, 2025
alice-i-cecile
alice-i-cecile approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean; thanks!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 7, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 7, 2025
Merged via the queue into bevyengine:main with commit 3578f9e Jan 7, 2025
33 checks passed
@alice-i-cecile alice-i-cecile mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@viridia viridia viridia approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

bevy_input_focus types should all be Reflect
4 participants
@chompaa @viridia @alice-i-cecile @BenjaminBrienen