Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_input_focus types should all be Reflect #17099

Closed
alice-i-cecile opened this issue Jan 2, 2025 · 0 comments · Fixed by #17212
Closed

bevy_input_focus types should all be Reflect #17099

alice-i-cecile opened this issue Jan 2, 2025 · 0 comments · Fixed by #17212
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Milestone
0.16

Comments

@alice-i-cecile
Copy link
Member

Derive the types, register them, and stick it all behind a feature flag, just like our other crates :)

This is essential to ensure that the types play nice with inspector-style tooling.
@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jan 2, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 2, 2025
@chompaa chompaa mentioned this issue Jan 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025
@chompaa
Reflect bevy_input_focus (#17212)
3578f9e 
# Objective

Fixes #17099.

## Solution

Derive, register, and feature flag.

## Testing

Ran CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Reflect bevy_input_focus chompaa/bevy
1 participant
@alice-i-cecile