Fixed bug with stroke caused by parent g fix

beveradb · Mar 8, 2024 · 73b0fc9 · 73b0fc9
1 parent b13c09e
commit 73b0fc9
Show file tree

Hide file tree

Showing 8 changed files with 158 additions and 156 deletions.
diff --git a/examples/full.example.dark_logos.png b/examples/full.example.dark_logos.png
diff --git a/examples/full.example.dark_logos.svg b/examples/full.example.dark_logos.svg
diff --git a/examples/full.example.dark_text.svg b/examples/full.example.dark_text.svg
diff --git a/examples/full.example.light_logos.png b/examples/full.example.light_logos.png
diff --git a/examples/full.example.light_logos.svg b/examples/full.example.light_logos.svg
diff --git a/examples/full.example.light_text.svg b/examples/full.example.light_text.svg
diff --git a/logo_diagram_generator/generate_diagram.py b/logo_diagram_generator/generate_diagram.py
@@ -249,10 +249,9 @@ def embed_logos_in_diagram(diagram_name, diagram_svg_path, output_svg_path, conf
             logo_node.setAttribute("width", str(logo_orig_width))
             logo_node.setAttribute("height", str(logo_orig_height))
 
-            # Append the logo_node to the newly created <g> element
-            logo_parent_g_element.appendChild(logo_node)
-
             if logo_stroke_color is not None and float(logo_stroke_width) > 0:
+                logging.debug(f"Adding stroke to logo with color {logo_stroke_color} and width {logo_stroke_width}")
+
                 # List of SVG shape tags to add strokes to
                 shape_tags = ["path", "rect", "circle", "ellipse", "line", "polyline", "polygon"]
 
@@ -262,6 +261,9 @@ def embed_logos_in_diagram(diagram_name, diagram_svg_path, output_svg_path, conf
                         element.setAttribute("stroke", logo_stroke_color)
                         element.setAttribute("stroke-width", str(logo_stroke_width))
 
+            # Append the logo_node to the newly created <g> element
+            logo_parent_g_element.appendChild(logo_node)
+
             # Remove the tool node completely and insert the logo node at the end of the diagram documentElement
             tool_node.parentNode.removeChild(tool_node)
             diagram_graph_node.appendChild(logo_parent_g_element)

diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "logo-diagram-generator"
-version = "0.3.4"
+version = "0.3.5"
 description = "Generate SVG diagrams of a (tech) ecosystem, using logos from each tool organised into groups around a central logo"
 authors = ["Andrew Beveridge <[email protected]>"]
 license = "MIT"