Fixed incorrect formula to find new amperage scale using battery charger measurement in Wiki #519
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-betaflight-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ramkrishna757575
changed the title
haslinghuis
reviewed
Feb 9, 2025
docs/development/Battery.md
Outdated
| amperage_meter_scale = old_amperage_meter_scale * (mAh_recharged / cleanflight_reported_mAh_drawn) | ||
| = 400 * (1500 / 2000) | ||
| = 300 | ||
| amperage_meter_scale = old_amperage_meter_scale * (cleanflight_reported_mAh_drawn / mAh_recharged) |
There was a problem hiding this comment.
Suggested change
| amperage_meter_scale = old_amperage_meter_scale * (cleanflight_reported_mAh_drawn / mAh_recharged) | |
| amperage_meter_scale = old_amperage_meter_scale * (reported_mAh_drawn / mAh_recharged) |
There was a problem hiding this comment.
@haslinghuis I have now removed the cleanflight prefix from the formula
There was a problem hiding this comment.
@ramkrishna757575 removed other non related references (for the sake of consistency) - hope you appreciate.
There was a problem hiding this comment.
@ramkrishna757575 removed other non related references (for the sake of consistency) - hope you appreciate.
sure...thanks for the review and the updates to the PR :)
haslinghuis
previously approved these changes
Feb 9, 2025
|
haslinghuis
approved these changes
Feb 9, 2025
VitroidFPV
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The battery charger measurement method to tune the amperage scale state the formula as:
This is incorrect. The actual formula should be: