Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add comfyui example #5077

Merged
merged 6 commits into from
Nov 11, 2024
Merged

doc: add comfyui example #5077

merged 6 commits into from
Nov 11, 2024

Conversation

ssheng
Copy link
Collaborator

@ssheng ssheng commented Nov 11, 2024

What does this PR address?

Fixes #(issue)

Before submitting:

@ssheng ssheng requested a review from a team as a code owner November 11, 2024 11:57
@ssheng ssheng requested review from parano and removed request for a team November 11, 2024 11:57
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 6 total issue(s) found.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • APIs

docs/source/use-cases/diffusion-models/comfyui.rst Outdated Show resolved Hide resolved
docs/source/use-cases/diffusion-models/comfyui.rst Outdated Show resolved Hide resolved
docs/source/use-cases/diffusion-models/comfyui.rst Outdated Show resolved Hide resolved
Build the workflow as a Bento
-----------------------------

In this step, we build the workspace and workflow as a Bento. We require the workflow API JSON file and the workspace model we saved in the previous steps. Underneath the hood, BentoML freezes the current Python virtual environment as dependency and genereates a service module with the serving logic for the workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this step, we build the workspace and workflow as a Bento. We require the workflow API JSON file and the workspace model we saved in the previous steps. Underneath the hood, BentoML freezes the current Python virtual environment as dependency and genereates a service module with the serving logic for the workflow.
In this step, we build the workspace and workflow as a BentoML package. We require the workflow API JSON file and the workspace model we saved in the previous steps. Underneath the hood, BentoML freezes the current Python virtual environment as dependency and generates a service module with the serving logic for the workflow.

Issues:

  • Style Guide - (Spelling-error) Did you really mean 'Bento'?
  • Style Guide - (Spelling-error) Did you really mean 'genereates'?

Fix Explanation:

The term 'Bento' might be a shorthand for 'BentoML', but to avoid confusion, it's better to use the full term 'BentoML' unless 'Bento' is a defined term in the documentation. Also, corrected 'genereates' to 'generates'.

ssheng and others added 3 commits November 11, 2024 03:58
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
@bentoml bentoml deleted a comment from hyperlint-ai bot Nov 11, 2024
@bentoml bentoml deleted a comment from hyperlint-ai bot Nov 11, 2024
@ssheng ssheng merged commit 2cc1f8f into bentoml:main Nov 11, 2024
4 of 6 checks passed
@ssheng ssheng deleted the doc-comfyui branch November 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant